javier/Wino-Mail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

better 404 handling.

Browse Source
This commit is contained in:
Burak Kaan Köse
2026-04-07 13:23:07 +02:00
parent a9fd624742
commit 3db54023a4
7 changed files with 197 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Wino.Core.Tests/Synchronizers/GmailSynchronizerRequestSuccessTests.cs
+65
View File
@@ -5,6 +5,7 @@ using FluentAssertions;
using Google.Apis.Requests;
using Moq;
using Wino.Core.Domain.Entities.Mail;
using Wino.Core.Domain.Exceptions;
using Wino.Core.Domain.Entities.Shared;
using Wino.Core.Domain.Interfaces;
using Wino.Core.Domain.Models.Synchronization;
@@ -142,6 +143,70 @@ public sealed class GmailSynchronizerRequestSuccessTests
errorFactory.Verify(x => x.HandleErrorAsync(It.IsAny<SynchronizerErrorContext>()), Times.Once);
}
[Fact]
public async Task ProcessSingleNativeRequestResponseAsync_Generic404Error_DoesNotClassifyAsEntityNotFound()
{
var changeProcessor = new Mock<IGmailChangeProcessor>(MockBehavior.Strict);
SynchronizerErrorContext? capturedContext = null;
var errorFactory = new Mock<IGmailSynchronizerErrorHandlerFactory>(MockBehavior.Strict);
errorFactory
.Setup(x => x.HandleErrorAsync(It.IsAny<SynchronizerErrorContext>()))
.Callback<SynchronizerErrorContext>(context => capturedContext = context)
.ReturnsAsync(false);
var synchronizer = CreateSynchronizer(changeProcessor.Object, errorFactory.Object);
var request = new DeleteRequest(CreateMailCopy("mail-1"));
var bundle = new HttpRequestBundle<IClientServiceRequest>(Mock.Of<IClientServiceRequest>(), request, request);
using var response = new HttpResponseMessage(HttpStatusCode.OK)
{
Content = new StringContent(string.Empty)
};
var error = new RequestError
{
Code = 404,
Message = "Not Found"
};
var act = () => InvokeProcessSingleNativeRequestResponseAsync(synchronizer, bundle, response, error);
await act.Should().ThrowAsync<SynchronizerException>();
capturedContext.Should().NotBeNull();
capturedContext!.IsEntityNotFound.Should().BeFalse();
}
[Fact]
public async Task ProcessSingleNativeRequestResponseAsync_Entity404Error_ClassifiesAsEntityNotFound()
{
var changeProcessor = new Mock<IGmailChangeProcessor>(MockBehavior.Strict);
SynchronizerErrorContext? capturedContext = null;
var errorFactory = new Mock<IGmailSynchronizerErrorHandlerFactory>(MockBehavior.Strict);
errorFactory
.Setup(x => x.HandleErrorAsync(It.IsAny<SynchronizerErrorContext>()))
.Callback<SynchronizerErrorContext>(context => capturedContext = context)
.ReturnsAsync(false);
var synchronizer = CreateSynchronizer(changeProcessor.Object, errorFactory.Object);
var request = new DeleteRequest(CreateMailCopy("mail-1"));
var bundle = new HttpRequestBundle<IClientServiceRequest>(Mock.Of<IClientServiceRequest>(), request, request);
using var response = new HttpResponseMessage(HttpStatusCode.OK)
{
Content = new StringContent(string.Empty)
};
var error = new RequestError
{
Code = 404,
Message = "Requested entity was not found."
};
var act = () => InvokeProcessSingleNativeRequestResponseAsync(synchronizer, bundle, response, error);
await act.Should().ThrowAsync<SynchronizerEntityNotFoundException>();
capturedContext.Should().NotBeNull();
capturedContext!.IsEntityNotFound.Should().BeTrue();
}
private static GmailSynchronizer CreateSynchronizer(
IGmailChangeProcessor changeProcessor,
IGmailSynchronizerErrorHandlerFactory? errorFactory = null)