javier/Wino-Mail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes Webview jumps when navigating emails and added Tooltips to the collapsed nav view. (#373)

Browse Source 
* Prepare To/Cc/Bcc info in advance to avoid layout shifts

* Changed tooltips in nav view to apply to whole element instead of content

* Revert comment
This commit is contained in:
Tiktack
2024-09-14 18:41:33 +02:00
committed by GitHub
parent 12f821fd6b
commit 4ac8095554
3 changed files with 52 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Wino.Mail/AppShell.xaml
View File

@@ -190,7 +190,8 @@
IsExpanded="{x:Bind IsExpanded, Mode=TwoWay}"
IsSelected="{x:Bind IsSelected, Mode=TwoWay}"
MenuItemsSource="{x:Bind SubMenuItems, Mode=OneWay}"
SelectsOnInvoked="{x:Bind IsMoveTarget, Mode=OneWay}">
SelectsOnInvoked="{x:Bind IsMoveTarget, Mode=OneWay}"
ToolTipService.ToolTip="{x:Bind FolderName, Mode=OneWay}">
<animations:Implicit.Animations>
<animations:ScaleAnimation Duration="0:0:0.5" />
</animations:Implicit.Animations>
@@ -210,9 +211,6 @@
x:Name="FolderBackgroundGrid"
Padding="2"
VerticalAlignment="Center">
<ToolTipService.ToolTip>
<ToolTip Content="{x:Bind FolderName, Mode=OneWay}" />
</ToolTipService.ToolTip>
<Grid
x:Name="BackgroundColorGrid"
x:Load="{x:Bind HasTextColor, Mode=OneWay}"
@@ -308,7 +306,8 @@
FontWeight="{x:Bind helpers:XamlHelpers.GetFontWeightByChildSelectedState(IsSelected), Mode=OneWay}"
IsExpanded="{x:Bind IsExpanded, Mode=TwoWay}"
IsSelected="{x:Bind IsSelected, Mode=TwoWay}"
SelectsOnInvoked="True">
SelectsOnInvoked="True"
ToolTipService.ToolTip="{x:Bind FolderName, Mode=OneWay}">
<animations:Implicit.Animations>
<animations:ScaleAnimation Duration="0:0:0.5" />
</animations:Implicit.Animations>
@@ -327,9 +326,6 @@
x:Name="FolderBackgroundGrid"
Padding="2"
VerticalAlignment="Center">
<ToolTipService.ToolTip>
<ToolTip Content="{x:Bind FolderName, Mode=OneWay}" />
</ToolTipService.ToolTip>
<TextBlock
x:Name="NormalTitle"
VerticalAlignment="Center"

12
Wino.Mail/Views/MailRenderingPage.xaml
View File

@@ -263,12 +263,12 @@
VerticalAlignment="Center"
FontWeight="SemiBold"
Text="Cc:"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.CCItemsItems.Count), Mode=OneWay}" />
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.CcItems.Count), Mode=OneWay}" />
<ItemsControl
Grid.Column="1"
ItemTemplate="{StaticResource InternetAddressTemplate}"
ItemsSource="{x:Bind ViewModel.CCItemsItems, Mode=OneWay}"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.CCItemsItems.Count), Mode=OneWay}">
ItemsSource="{x:Bind ViewModel.CcItems, Mode=OneWay}"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.CcItems.Count), Mode=OneWay}">
<ItemsControl.ItemsPanel>
<ItemsPanelTemplate>
<toolkit:WrapPanel Orientation="Horizontal" />
@@ -286,13 +286,13 @@
VerticalAlignment="Center"
FontWeight="SemiBold"
Text="Bcc:"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.BCCItems.Count), Mode=OneWay}" />
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.BccItems.Count), Mode=OneWay}" />
<ItemsControl
Grid.Column="1"
ItemTemplate="{StaticResource InternetAddressTemplate}"
ItemsSource="{x:Bind ViewModel.BCCItems, Mode=OneWay}"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.BCCItems.Count), Mode=OneWay}">
ItemsSource="{x:Bind ViewModel.BccItems, Mode=OneWay}"
Visibility="{x:Bind helpers:XamlHelpers.CountToVisibilityConverter(ViewModel.BccItems.Count), Mode=OneWay}">
<ItemsControl.ItemsPanel>
<ItemsPanelTemplate>
<toolkit:WrapPanel Orientation="Horizontal" />