javier/Wino-Mail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some miscellaneous cleanup (#494)

Browse Source 
* Updating CONTRIBUTING guidelines

* Adding PackageCertificateKeyFile ref to Calendar proj to allow building on fresh machines

* Adding missing conversions to MailSync type
This commit is contained in:
Benjin Dubishar
2024-12-27 11:27:45 -08:00
committed by GitHub
parent fbc3ca4517
commit 8e129c561d
8 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
CONTRIBUTING.md
View File

@@ -15,7 +15,12 @@ Wino Mail is [Universal Windows Platform](https://learn.microsoft.com/en-us/wind
**Min Version:** Windows 10 1809 **Min Version:** Windows 10 1809
**Target Version:** Windows 11 22H2 **Target Version:** Windows 11 22H2
It's pretty straightforward after cloning the repo. There are no prerequisites needed. Just open **Wino.sln** solution in your IDE and launch. ## Prerequisites
* ".NET desktop development" workload in Visual Studio 2022+
* .NET SDK 8.0+
With those installed, it's pretty straightforward after cloning the repo. Just open **Wino.sln** solution in your IDE and launch.
## Project Architecture ## Project Architecture

4
Wino.Calendar/Wino.Calendar.csproj
View File

@@ -6,6 +6,8 @@
<RestoreProjectStyle>PackageReference</RestoreProjectStyle> <RestoreProjectStyle>PackageReference</RestoreProjectStyle>
<!-- UWP WAM Authentication on Xbox needs this. --> <!-- UWP WAM Authentication on Xbox needs this. -->
<UseDotNetNativeSharedAssemblyFrameworkPackage>false</UseDotNetNativeSharedAssemblyFrameworkPackage> <UseDotNetNativeSharedAssemblyFrameworkPackage>false</UseDotNetNativeSharedAssemblyFrameworkPackage>
<PackageCertificateThumbprint>125A5273FCFE8D551C3FED87F67C87A663E98F1B</PackageCertificateThumbprint>
<PackageCertificateKeyFile>Wino.Mail_TemporaryKey.pfx</PackageCertificateKeyFile>
<GenerateAppInstallerFile>False</GenerateAppInstallerFile> <GenerateAppInstallerFile>False</GenerateAppInstallerFile>
<AppxPackageSigningTimestampDigestAlgorithm>SHA256</AppxPackageSigningTimestampDigestAlgorithm> <AppxPackageSigningTimestampDigestAlgorithm>SHA256</AppxPackageSigningTimestampDigestAlgorithm>
<AppxAutoIncrementPackageRevision>True</AppxAutoIncrementPackageRevision> <AppxAutoIncrementPackageRevision>True</AppxAutoIncrementPackageRevision>
@@ -32,8 +34,6 @@
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview> <WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
<AppxPackageSigningEnabled>True</AppxPackageSigningEnabled> <AppxPackageSigningEnabled>True</AppxPackageSigningEnabled>
<PackageCertificateThumbprint>125A5273FCFE8D551C3FED87F67C87A663E98F1B</PackageCertificateThumbprint>
<PackageCertificateKeyFile />
<GenerateTemporaryStoreCertificate>True</GenerateTemporaryStoreCertificate> <GenerateTemporaryStoreCertificate>True</GenerateTemporaryStoreCertificate>
</PropertyGroup> </PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'"> <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">

6
Wino.Mail.ViewModels/AccountManagementViewModel.cs
View File

@@ -165,7 +165,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.UpdateProfile Type = MailSynchronizationType.UpdateProfile
}; };
var profileSynchronizationResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewSynchronizationRequested>(new NewSynchronizationRequested(profileSyncOptions, SynchronizationSource.Client)); var profileSynchronizationResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewMailSynchronizationRequested>(new NewMailSynchronizationRequested(profileSyncOptions, SynchronizationSource.Client));
var profileSynchronizationResult = profileSynchronizationResponse.Data; var profileSynchronizationResult = profileSynchronizationResponse.Data;
@@ -195,7 +195,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.FoldersOnly Type = MailSynchronizationType.FoldersOnly
}; };
var folderSynchronizationResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewSynchronizationRequested>(new NewSynchronizationRequested(folderSyncOptions, SynchronizationSource.Client)); var folderSynchronizationResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewMailSynchronizationRequested>(new NewMailSynchronizationRequested(folderSyncOptions, SynchronizationSource.Client));
var folderSynchronizationResult = folderSynchronizationResponse.Data; var folderSynchronizationResult = folderSynchronizationResponse.Data;
@@ -213,7 +213,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.Alias Type = MailSynchronizationType.Alias
}; };
var aliasSyncResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewSynchronizationRequested>(new NewSynchronizationRequested(aliasSyncOptions, SynchronizationSource.Client)); var aliasSyncResponse = await WinoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewMailSynchronizationRequested>(new NewMailSynchronizationRequested(aliasSyncOptions, SynchronizationSource.Client));
var aliasSynchronizationResult = folderSynchronizationResponse.Data; var aliasSynchronizationResult = folderSynchronizationResponse.Data;
if (aliasSynchronizationResult.CompletedState != SynchronizationCompletedState.Success) if (aliasSynchronizationResult.CompletedState != SynchronizationCompletedState.Success)

2
Wino.Mail.ViewModels/AliasManagementPageViewModel.cs
View File

@@ -82,7 +82,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.Alias Type = MailSynchronizationType.Alias
}; };
var aliasSyncResponse = await _winoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewSynchronizationRequested>(new NewSynchronizationRequested(aliasSyncOptions, SynchronizationSource.Client)); var aliasSyncResponse = await _winoServerConnectionManager.GetResponseAsync<MailSynchronizationResult, NewMailSynchronizationRequested>(new NewMailSynchronizationRequested(aliasSyncOptions, SynchronizationSource.Client));
if (aliasSyncResponse.IsSuccess) if (aliasSyncResponse.IsSuccess)
await LoadAliasesAsync(); await LoadAliasesAsync();

4
Wino.Mail.ViewModels/AppShellViewModel.cs
View File

@@ -318,7 +318,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.FullFolders Type = MailSynchronizationType.FullFolders
}; };
Messenger.Send(new NewSynchronizationRequested(options, SynchronizationSource.Client)); Messenger.Send(new NewMailSynchronizationRequested(options, SynchronizationSource.Client));
} }
} }
@@ -891,7 +891,7 @@ namespace Wino.Mail.ViewModels
Type = MailSynchronizationType.FullFolders, Type = MailSynchronizationType.FullFolders,
}; };
Messenger.Send(new NewSynchronizationRequested(options, SynchronizationSource.Client)); Messenger.Send(new NewMailSynchronizationRequested(options, SynchronizationSource.Client));
try try
{ {

6
Wino.Mail.ViewModels/MailListPageViewModel.cs
View File

@@ -40,7 +40,7 @@ namespace Wino.Mail.ViewModels
IRecipient<MailItemSelectedEvent>, IRecipient<MailItemSelectedEvent>,
IRecipient<MailItemSelectionRemovedEvent>, IRecipient<MailItemSelectionRemovedEvent>,
IRecipient<AccountSynchronizationCompleted>, IRecipient<AccountSynchronizationCompleted>,
IRecipient<NewSynchronizationRequested>, IRecipient<NewMailSynchronizationRequested>,
IRecipient<AccountSynchronizerStateChanged> IRecipient<AccountSynchronizerStateChanged>
{ {
private bool isChangingFolder = false; private bool isChangingFolder = false;
@@ -479,7 +479,7 @@ namespace Wino.Mail.ViewModels
GroupedSynchronizationTrackingId = trackingSynchronizationId GroupedSynchronizationTrackingId = trackingSynchronizationId
}; };
Messenger.Send(new NewSynchronizationRequested(options, SynchronizationSource.Client)); Messenger.Send(new NewMailSynchronizationRequested(options, SynchronizationSource.Client));
} }
} }
@@ -989,7 +989,7 @@ namespace Wino.Mail.ViewModels
#endregion #endregion
public async void Receive(NewSynchronizationRequested message) public async void Receive(NewMailSynchronizationRequested message)
=> await ExecuteUIThread(() => { OnPropertyChanged(nameof(CanSynchronize)); }); => await ExecuteUIThread(() => { OnPropertyChanged(nameof(CanSynchronize)); });
protected override async void OnFolderSynchronizationEnabled(IMailItemFolder mailItemFolder) protected override async void OnFolderSynchronizationEnabled(IMailItemFolder mailItemFolder)

2
Wino.Mail/Services/DialogService.cs
View File

@@ -97,7 +97,7 @@ namespace Wino.Services
Type = MailSynchronizationType.FullFolders, Type = MailSynchronizationType.FullFolders,
}; };
WeakReferenceMessenger.Default.Send(new NewSynchronizationRequested(options, SynchronizationSource.Client)); WeakReferenceMessenger.Default.Send(new NewMailSynchronizationRequested(options, SynchronizationSource.Client));
} }
} }
catch (Exception ex) catch (Exception ex)

2
Wino.Mail/Wino.Mail.csproj
View File

@@ -7,6 +7,7 @@
<!-- UWP WAM Authentication on Xbox needs this. --> <!-- UWP WAM Authentication on Xbox needs this. -->
<UseDotNetNativeSharedAssemblyFrameworkPackage>false</UseDotNetNativeSharedAssemblyFrameworkPackage> <UseDotNetNativeSharedAssemblyFrameworkPackage>false</UseDotNetNativeSharedAssemblyFrameworkPackage>
<PackageCertificateThumbprint>3B34414D49FBF00A35A040085092D8699459EA8E</PackageCertificateThumbprint> <PackageCertificateThumbprint>3B34414D49FBF00A35A040085092D8699459EA8E</PackageCertificateThumbprint>
<PackageCertificateKeyFile>Wino.Mail_TemporaryKey.pfx</PackageCertificateKeyFile>
</PropertyGroup> </PropertyGroup>
<PropertyGroup> <PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -24,7 +25,6 @@
<FileAlignment>512</FileAlignment> <FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview> <WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
<PackageCertificateKeyFile>Wino.Mail_TemporaryKey.pfx</PackageCertificateKeyFile>
<GenerateAppInstallerFile>False</GenerateAppInstallerFile> <GenerateAppInstallerFile>False</GenerateAppInstallerFile>
<AppxPackageSigningTimestampDigestAlgorithm>SHA256</AppxPackageSigningTimestampDigestAlgorithm> <AppxPackageSigningTimestampDigestAlgorithm>SHA256</AppxPackageSigningTimestampDigestAlgorithm>
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision> <AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision>