From c3f47c5fa13026f24a4c2e9747882fba4e7a0772 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Burak=20Kaan=20K=C3=B6se?= <bkaankose@outlook.com>
Date: Sat, 26 Apr 2025 11:02:41 +0200
Subject: [PATCH] Check account notification preferences after the
 synchronization. (#647)

---
 Wino.Core.Domain/Interfaces/IAccountService.cs            | 8 ++++++++
 .../MessageHandlers/MailSynchronizationRequestHandler.cs  | 7 ++++++-
 Wino.Services/AccountService.cs                           | 7 +++++++
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/Wino.Core.Domain/Interfaces/IAccountService.cs b/Wino.Core.Domain/Interfaces/IAccountService.cs
index 96c38315..63aba714 100644
--- a/Wino.Core.Domain/Interfaces/IAccountService.cs
+++ b/Wino.Core.Domain/Interfaces/IAccountService.cs
@@ -162,4 +162,12 @@ public interface IAccountService
     /// <param name="accountId">Identifies the account for which the synchronization identifier is being updated.</param>
     /// <param name="syncIdentifier">Represents the new synchronization identifier to be set for the specified account.</param>
     Task<string> UpdateSyncIdentifierRawAsync(Guid accountId, string syncIdentifier);
+
+
+    /// <summary>
+    /// Gets whether the notifications are enabled for the given account id.
+    /// </summary>
+    /// <param name="accountId">Account id.</param>
+    /// <returns>Whether the notifications should be created after sync or not.</returns>
+    Task<bool> IsNotificationsEnabled(Guid accountId);
 }
diff --git a/Wino.Server/MessageHandlers/MailSynchronizationRequestHandler.cs b/Wino.Server/MessageHandlers/MailSynchronizationRequestHandler.cs
index 47134a09..e888c3fe 100644
--- a/Wino.Server/MessageHandlers/MailSynchronizationRequestHandler.cs
+++ b/Wino.Server/MessageHandlers/MailSynchronizationRequestHandler.cs
@@ -23,14 +23,17 @@ public class MailSynchronizationRequestHandler : ServerMessageHandler<NewMailSyn
 
     private readonly ISynchronizerFactory _synchronizerFactory;
     private readonly INotificationBuilder _notificationBuilder;
+    private readonly IAccountService _accountService;
     private readonly IFolderService _folderService;
 
     public MailSynchronizationRequestHandler(ISynchronizerFactory synchronizerFactory,
                                          INotificationBuilder notificationBuilder,
+                                         IAccountService accountService,
                                          IFolderService folderService)
     {
         _synchronizerFactory = synchronizerFactory;
         _notificationBuilder = notificationBuilder;
+        _accountService = accountService;
         _folderService = folderService;
     }
 
@@ -53,7 +56,9 @@ public class MailSynchronizationRequestHandler : ServerMessageHandler<NewMailSyn
         {
             var synchronizationResult = await synchronizer.SynchronizeMailsAsync(message.Options, cancellationToken).ConfigureAwait(false);
 
-            if (synchronizationResult.DownloadedMessages?.Any() ?? false || !synchronizer.Account.Preferences.IsNotificationsEnabled)
+            bool isNotificationsEnabled = await _accountService.IsNotificationsEnabled(synchronizer.Account.Id).ConfigureAwait(false);
+
+            if (isNotificationsEnabled && (synchronizationResult.DownloadedMessages?.Any() ?? false))
             {
                 var accountInboxFolder = await _folderService.GetSpecialFolderByAccountIdAsync(message.Options.AccountId, SpecialFolderType.Inbox);
 
diff --git a/Wino.Services/AccountService.cs b/Wino.Services/AccountService.cs
index 49fad9de..e2f9fcf7 100644
--- a/Wino.Services/AccountService.cs
+++ b/Wino.Services/AccountService.cs
@@ -615,4 +615,11 @@ public class AccountService : BaseDatabaseService, IAccountService
         var account = await GetAccountAsync(accountId);
         return account.Preferences.IsFocusedInboxEnabled.GetValueOrDefault();
     }
+
+    public async Task<bool> IsNotificationsEnabled(Guid accountId)
+    {
+        var account = await GetAccountAsync(accountId);
+
+        return account?.Preferences?.IsNotificationsEnabled ?? false;
+    }
 }