javier/Wino-Mail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ignore local calendar applying changes to prevent duplicate operations.

Browse Source
This commit is contained in:
Burak Kaan Köse
2026-02-15 19:44:07 +01:00
parent ff25db3fea
commit d428a6ce7a
2 changed files with 36 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Wino.Core/Synchronizers/ImapSynchronizer.cs
+27 -3
View File
@@ -705,7 +705,10 @@ public class ImapSynchronizer : WinoSynchronizer<ImapRequest, ImapMessageCreatio
foreach (var item in batchedRequests)
{
item.Request.ApplyUIChanges();
if (ShouldApplyOptimisticUIChanges(item.Request))
{
item.Request.ApplyUIChanges();
}
}
// All task bundles will execute on the same client.
@@ -734,7 +737,10 @@ public class ImapSynchronizer : WinoSynchronizer<ImapRequest, ImapMessageCreatio
// Client pool failed to get a client.
// Requests may not be executed at this point.
item.Request.RevertUIChanges();
if (ShouldApplyOptimisticUIChanges(item.Request))
{
item.Request.RevertUIChanges();
}
isCrashed = true;
throw;
@@ -768,7 +774,10 @@ public class ImapSynchronizer : WinoSynchronizer<ImapRequest, ImapMessageCreatio
if (!handled)
{
item.Request.RevertUIChanges();
if (ShouldApplyOptimisticUIChanges(item.Request))
{
item.Request.RevertUIChanges();
}
throw;
}
}
@@ -782,6 +791,21 @@ public class ImapSynchronizer : WinoSynchronizer<ImapRequest, ImapMessageCreatio
}
}
private bool ShouldApplyOptimisticUIChanges(IRequestBase request)
{
// Mail changes are always applied.
// Calendar changes are applied only if calendar is not in local mode.
// Database updates are immidiate and will be reflected in the UI right after the request is processed, so no need for optimistic changes.
if (request is not ICalendarActionRequest)
{
return true;
}
var mode = Account.ServerInformation?.CalendarSupportMode ?? ImapCalendarSupportMode.Disabled;
return mode != ImapCalendarSupportMode.LocalOnly;
}
/// <summary>
/// Assigns special folder type for the given local folder.
/// If server doesn't support special folders, we can't determine the type. MailKit will throw for GetFolder.