Improved outlook online search even more and removed redundant methods from ChangeProcessor (#586)

1.  Moved the IsBackground property assignment into the object initializer for the Thread object.

2. Replaced e.Args[e.Args.Length - 1] with e.Args[^1]

3. Added a conditional check to see if GetWindowThreadProcessId returns 0, which indicates failure. If it fails, throw a Win32Exception with the last Win32 error.

4. Removed unused assignment to the variable process

5. Changed the return type of the ConfigureServices method from IServiceProvider to ServiceProvider. It is more specific and faster.

6. Changed notifyIcon to _notifyIcon according to private var naming scheme.

7. Added the CharSet = CharSet.Unicode attribute to the DllImport declarations to specify that the string arguments should be marshaled as Unicode.

.editorconfig

@@ -149,7 +149,7 @@ csharp_preferred_modifier_order = public,private,protected,internal,static,exter
 # Code-block preferences
 csharp_prefer_braces = true:silent
 csharp_prefer_simple_using_statement = true:suggestion
-csharp_style_namespace_declarations = block_scoped:silent
+csharp_style_namespace_declarations = file_scoped:error
 
 # Expression-level preferences
 csharp_prefer_simple_default_expression = true:suggestion
@@ -288,3 +288,5 @@ csharp_style_prefer_utf8_string_literals = true:suggestion
 csharp_style_prefer_readonly_struct = true:suggestion
 csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true:silent
 csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true:silent
+csharp_style_prefer_primary_constructors = true:silent
+csharp_prefer_system_threading_lock = true:suggestion

Directory.Packages.props

@@ -7,6 +7,7 @@
         <PackageVersion Include="CommunityToolkit.Common" Version="8.4.0" />
         <PackageVersion Include="CommunityToolkit.Diagnostics" Version="8.4.0" />
         <PackageVersion Include="CommunityToolkit.Labs.Uwp.Controls.MarkdownTextBlock" Version="0.1.250206-build.2040" />
+        <PackageVersion Include="CommunityToolkit.Labs.Uwp.DependencyPropertyGenerator" Version="0.1.250206-build.2040" />
         <PackageVersion Include="CommunityToolkit.Mvvm" Version="8.4.0" />
         <PackageVersion Include="CommunityToolkit.Uwp.Animations" Version="8.2.250129-preview2" />
         <PackageVersion Include="CommunityToolkit.Uwp.Behaviors" Version="8.2.250129-preview2" />

Wino.Authentication/BaseAuthenticator.cs

@@ -1,8 +1,8 @@
 using Wino.Core.Domain.Enums;
 using Wino.Core.Domain.Interfaces;
 
-namespace Wino.Authentication
+namespace Wino.Authentication;
-{
+
 public abstract class BaseAuthenticator
 {
     public abstract MailProviderType ProviderType { get; }
@@ -14,4 +14,3 @@ namespace Wino.Authentication
         AuthenticatorConfig = authenticatorConfig;
     }
 }
-}

Wino.Authentication/GmailAuthenticator.cs

@@ -7,8 +7,8 @@ using Wino.Core.Domain.Enums;
 using Wino.Core.Domain.Interfaces;
 using Wino.Core.Domain.Models.Authentication;
 
-namespace Wino.Authentication
+namespace Wino.Authentication;
-{
+
 public class GmailAuthenticator : BaseAuthenticator, IGmailAuthenticator
 {
     public GmailAuthenticator(IAuthenticatorConfig authConfig) : base(authConfig)
@@ -48,4 +48,3 @@ namespace Wino.Authentication
         }, AuthenticatorConfig.GmailScope, account.Id.ToString(), CancellationToken.None, new FileDataStore(AuthenticatorConfig.GmailTokenStoreIdentifier));
     }
 }
-}

Wino.Authentication/OutlookAuthenticator.cs

@@ -11,8 +11,8 @@ using Wino.Core.Domain.Exceptions;
 using Wino.Core.Domain.Interfaces;
 using Wino.Core.Domain.Models.Authentication;
 
-namespace Wino.Authentication
+namespace Wino.Authentication;
-{
+
 public class OutlookAuthenticator : BaseAuthenticator, IOutlookAuthenticator
 {
     private const string TokenCacheFileName = "OutlookCache.bin";
@@ -123,4 +123,3 @@ namespace Wino.Authentication
         throw new AuthenticationException(Translator.Exception_UnknowErrorDuringAuthentication, new Exception(Translator.Exception_TokenGenerationFailed));
     }
 }
-}

Wino.Calendar/Services/CalendarAuthenticatorConfig.cs

@@ -1,7 +1,7 @@
 using Wino.Core.Domain.Interfaces;
 
-namespace Wino.Calendar.Services
+namespace Wino.Calendar.Services;
-{
+
 public class CalendarAuthenticatorConfig : IAuthenticatorConfig
 {
     public string OutlookAuthenticatorClientId => "b19c2035-d740-49ff-b297-de6ec561b208";
@@ -30,4 +30,3 @@ namespace Wino.Calendar.Services
 
     public string GmailTokenStoreIdentifier => "WinoCalendarGmailTokenStore";
 }
-}

Wino.Core.Domain/Collections/CalendarEventCollection.cs

@@ -7,8 +7,8 @@ using Wino.Core.Domain.Entities.Calendar;
 using Wino.Core.Domain.Interfaces;
 using Wino.Core.Domain.Models.Calendar;
 
-namespace Wino.Core.Domain.Collections
+namespace Wino.Core.Domain.Collections;
-{
+
 public class CalendarEventCollection
 {
     public event EventHandler<ICalendarItem> CalendarItemAdded;
@@ -153,4 +153,3 @@ namespace Wino.Core.Domain.Collections
         CalendarItemsCleared?.Invoke(this, EventArgs.Empty);
     }
 }
-}

Wino.Core.Domain/Collections/DayRangeCollection.cs

@@ -2,8 +2,8 @@
 using Wino.Core.Domain.Interfaces;
 using Wino.Core.Domain.Models.Calendar;
 
-namespace Wino.Core.Domain.Collections
+namespace Wino.Core.Domain.Collections;
-{
+
 public class DayRangeCollection : ObservableRangeCollection<DayRangeRenderModel>
 {
     /// <summary>
@@ -39,4 +39,3 @@ namespace Wino.Core.Domain.Collections
         }
     }
 }
-}

Wino.Core.Domain/Collections/ObservableRangeCollection.cs

@@ -4,8 +4,8 @@ using System.Collections.ObjectModel;
 using System.Collections.Specialized;
 using System.ComponentModel;
 
-namespace Wino.Core.Domain.Collections
+namespace Wino.Core.Domain.Collections;
-{
+
 /// <summary> 
 /// Represents a dynamic data collection that provides notifications when items get added, removed, or when the whole list is refreshed. 
 /// </summary> 
@@ -171,4 +171,3 @@ namespace Wino.Core.Domain.Collections
             OnCollectionChanged(new NotifyCollectionChangedEventArgs(action, changedItems: changedItems, startingIndex: startingIndex));
     }
 }
-}

Wino.Core.Domain/Constants.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain
+namespace Wino.Core.Domain;
-{
+
 public static class Constants
 {
     /// <summary>
@@ -20,4 +20,3 @@
     public const string WinoMailIdentiifer = nameof(WinoMailIdentiifer);
     public const string WinoCalendarIdentifier = nameof(WinoCalendarIdentifier);
 }
-}

Wino.Core.Domain/Entities/Calendar/AccountCalendar.cs

@@ -2,8 +2,8 @@
 using SQLite;
 using Wino.Core.Domain.Interfaces;
 
-namespace Wino.Core.Domain.Entities.Calendar
+namespace Wino.Core.Domain.Entities.Calendar;
-{
+
 public class AccountCalendar : IAccountCalendar
 {
     [PrimaryKey]
@@ -22,4 +22,3 @@ namespace Wino.Core.Domain.Entities.Calendar
     public string BackgroundColorHex { get; set; }
     public string TimeZone { get; set; }
 }
-}

Wino.Core.Domain/Entities/Calendar/CalendarEventAttendee.cs

@@ -2,8 +2,8 @@
 using SQLite;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Entities.Calendar
+namespace Wino.Core.Domain.Entities.Calendar;
-{
+
 // TODO: Connect to Contact store with Wino People.
 public class CalendarEventAttendee
 {
@@ -17,4 +17,3 @@ namespace Wino.Core.Domain.Entities.Calendar
     public bool IsOptionalAttendee { get; set; }
     public string Comment { get; set; }
 }
-}

Wino.Core.Domain/Entities/Calendar/CalendarItem.cs

@@ -5,8 +5,8 @@ using SQLite;
 using Wino.Core.Domain.Enums;
 using Wino.Core.Domain.Interfaces;
 
-namespace Wino.Core.Domain.Entities.Calendar
+namespace Wino.Core.Domain.Entities.Calendar;
-{
+
 [DebuggerDisplay("{Title} ({StartDate} - {EndDate})")]
 public class CalendarItem : ICalendarItem
 {
@@ -177,4 +177,3 @@ namespace Wino.Core.Domain.Entities.Calendar
         };
     }
 }
-}

Wino.Core.Domain/Entities/Calendar/Reminder.cs

@@ -2,8 +2,8 @@
 using SQLite;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Entities.Calendar
+namespace Wino.Core.Domain.Entities.Calendar;
-{
+
 public class Reminder
 {
     [PrimaryKey]
@@ -13,4 +13,3 @@ namespace Wino.Core.Domain.Entities.Calendar
     public DateTimeOffset ReminderTime { get; set; }
     public CalendarItemReminderType ReminderType { get; set; }
 }
-}

Wino.Core.Domain/Entities/Mail/AccountSignature.cs

@@ -1,8 +1,8 @@
 using System;
 using SQLite;
 
-namespace Wino.Core.Domain.Entities.Mail
+namespace Wino.Core.Domain.Entities.Mail;
-{
+
 public class AccountSignature
 {
     [PrimaryKey]
@@ -14,4 +14,3 @@ namespace Wino.Core.Domain.Entities.Mail
 
     public Guid MailAccountId { get; set; }
 }
-}

Wino.Core.Domain/Entities/Mail/MailAccountAlias.cs

@@ -1,8 +1,8 @@
 using System;
 using SQLite;
 
-namespace Wino.Core.Domain.Entities.Mail
+namespace Wino.Core.Domain.Entities.Mail;
-{
+
 public class RemoteAccountAlias
 {
     /// <summary>
@@ -60,4 +60,3 @@ namespace Wino.Core.Domain.Entities.Mail
     /// </summary>
     public bool CanDelete => !IsRootAlias;
 }
-}

Wino.Core.Domain/Entities/Mail/MailCopy.cs

@@ -5,8 +5,8 @@ using Wino.Core.Domain.Entities.Shared;
 using Wino.Core.Domain.Enums;
 using Wino.Core.Domain.Models.MailItem;
 
-namespace Wino.Core.Domain.Entities.Mail
+namespace Wino.Core.Domain.Entities.Mail;
-{
+
 /// <summary>
 /// Summary of the parsed MIME messages.
 /// Wino will do non-network operations on this table and others from the original MIME.
@@ -154,4 +154,3 @@ namespace Wino.Core.Domain.Entities.Mail
     public IEnumerable<Guid> GetContainingIds() => [UniqueId];
     public override string ToString() => $"{Subject} <-> {Id}";
 }
-}

Wino.Core.Domain/Entities/Mail/MailItemFolder.cs

@@ -5,8 +5,8 @@ using SQLite;
 using Wino.Core.Domain.Enums;
 using Wino.Core.Domain.Models.Folders;
 
-namespace Wino.Core.Domain.Entities.Mail
+namespace Wino.Core.Domain.Entities.Mail;
-{
+
 [DebuggerDisplay("{FolderName} - {SpecialFolderType}")]
 public class MailItemFolder : IMailItemFolder
 {
@@ -72,4 +72,3 @@ namespace Wino.Core.Domain.Entities.Mail
 
     public override string ToString() => FolderName;
 }
-}

Wino.Core.Domain/Entities/Mail/MergedInbox.cs

@@ -1,8 +1,8 @@
 using System;
 using SQLite;
 
-namespace Wino.Core.Domain.Entities.Mail
+namespace Wino.Core.Domain.Entities.Mail;
-{
+
 public class MergedInbox
 {
     [PrimaryKey]
@@ -10,4 +10,3 @@ namespace Wino.Core.Domain.Entities.Mail
 
     public string Name { get; set; }
 }
-}

Wino.Core.Domain/Entities/Shared/AccountContact.cs

@@ -2,8 +2,8 @@
 using System.Collections.Generic;
 using SQLite;
 
-namespace Wino.Core.Domain.Entities.Shared
+namespace Wino.Core.Domain.Entities.Shared;
-{
+
 /// <summary>
 /// Back storage for simple name-address book.
 /// These values will be inserted during MIME fetch.
@@ -36,14 +36,6 @@ namespace Wino.Core.Domain.Entities.Shared
     /// </summary>
     public bool IsRootContact { get; set; }
 
-        /// <summary>
-        /// Short display name of the contact.
-        /// Eather Name or Address.
-        /// </summary>
-        public string ShortDisplayName => Address == Name || string.IsNullOrWhiteSpace(Name) ? $"{Address.ToLowerInvariant()};" : $"{Name};";
-
-        public string DisplayName => Address == Name || string.IsNullOrWhiteSpace(Name) ? Address.ToLowerInvariant() : $"{Name} <{Address.ToLowerInvariant()}>";
-
     public override bool Equals(object obj)
     {
         return Equals(obj as AccountContact);
@@ -58,10 +50,7 @@ namespace Wino.Core.Domain.Entities.Shared
 
     public override int GetHashCode()
     {
-            int hashCode = -1717786383;
+        return HashCode.Combine(Address, Name);
-            hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Address);
-            hashCode = hashCode * -1521134295 + EqualityComparer<string>.Default.GetHashCode(Name);
-            return hashCode;
     }
 
     public static bool operator ==(AccountContact left, AccountContact right)
@@ -74,4 +63,3 @@ namespace Wino.Core.Domain.Entities.Shared
         return !(left == right);
     }
 }
-}

Wino.Core.Domain/Entities/Shared/CustomServerInformation.cs

@@ -1,9 +1,10 @@
 using System;
+using System.Collections.Generic;
 using SQLite;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Entities.Shared
+namespace Wino.Core.Domain.Entities.Shared;
-{
+
 public class CustomServerInformation
 {
     [PrimaryKey]
@@ -49,5 +50,25 @@ namespace Wino.Core.Domain.Entities.Shared
     /// Default is 5.
     /// </summary>
     public int MaxConcurrentClients { get; set; }
+
+    public Dictionary<string, string> GetConnectionProperties()
+    {
+        // Printout the public connection properties.
+
+        var connectionProperties = new Dictionary<string, string>
+        {
+            { "IncomingServer", IncomingServer },
+            { "IncomingServerPort", IncomingServerPort },
+            { "IncomingServerSocketOption", IncomingServerSocketOption.ToString() },
+            { "IncomingAuthenticationMethod", IncomingAuthenticationMethod.ToString() },
+            { "OutgoingServer", OutgoingServer },
+            { "OutgoingServerPort", OutgoingServerPort },
+            { "OutgoingServerSocketOption", OutgoingServerSocketOption.ToString() },
+            { "OutgoingAuthenticationMethod", OutgoingAuthenticationMethod.ToString() },
+            { "ProxyServer", ProxyServer },
+            { "ProxyServerPort", ProxyServerPort }
+        };
+
+        return connectionProperties;
     }
 }

Wino.Core.Domain/Entities/Shared/MailAccount.cs

@@ -3,8 +3,8 @@ using SQLite;
 using Wino.Core.Domain.Entities.Mail;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Entities.Shared
+namespace Wino.Core.Domain.Entities.Shared;
-{
+
 public class MailAccount
 {
     [PrimaryKey]
@@ -108,4 +108,3 @@ namespace Wino.Core.Domain.Entities.Shared
     /// </summary>
     public bool IsAliasSyncSupported => ProviderType == MailProviderType.Gmail;
 }
-}

Wino.Core.Domain/Entities/Shared/MailAccountPreferences.cs

@@ -1,8 +1,8 @@
 using System;
 using SQLite;
 
-namespace Wino.Core.Domain.Entities.Shared
+namespace Wino.Core.Domain.Entities.Shared;
-{
+
 public class MailAccountPreferences
 {
     [PrimaryKey]
@@ -51,4 +51,3 @@ namespace Wino.Core.Domain.Entities.Shared
     /// </summary>
     public Guid? SignatureIdForFollowingMessages { get; set; }
 }
-}

Wino.Core.Domain/Enums/AccountAttentionReason.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum AccountAttentionReason
 {
     None,
     InvalidCredentials,
     MissingSystemFolderConfiguration
 }
-}

Wino.Core.Domain/Enums/AccountCacheResetReason.cs

@@ -0,0 +1,7 @@
+namespace Wino.Core.Domain.Enums;
+
+public enum AccountCacheResetReason
+{
+    AccountRemoval,
+    ExpiredCache
+}

Wino.Core.Domain/Enums/AccountCreationDialogState.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum AccountCreationDialogState
 {
     Idle,
@@ -14,4 +14,3 @@
     Canceled,
     FetchingEvents
 }
-}

Wino.Core.Domain/Enums/AccountSynchronizerState.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Indicates the state of synchronizer.
 /// </summary>
@@ -9,4 +9,3 @@
     ExecutingRequests,
     Synchronizing
 }
-}

Wino.Core.Domain/Enums/AppLanguage.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum AppLanguage
 {
     None,
@@ -18,4 +18,3 @@
     Italian,
     Romanian
 }
-}

Wino.Core.Domain/Enums/AppThemeType.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum AppThemeType
 {
     System,
     PreDefined,
     Custom,
 }
-}

Wino.Core.Domain/Enums/ApplicationElementTheme.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum ApplicationElementTheme
 {
     Default,
     Light,
     Dark
 }
-}

Wino.Core.Domain/Enums/AttendeeStatus.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum AttendeeStatus
 {
     NeedsAction,
@@ -7,4 +7,3 @@
     Tentative,
     Declined
 }
-}

Wino.Core.Domain/Enums/BackgroundSynchronizationReason.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum BackgroundSynchronizationReason
 {
     SessionConnected,
     Timer
 }
-}

Wino.Core.Domain/Enums/CalendarDisplayType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarDisplayType
 {
     Day,
@@ -8,4 +8,3 @@
     Month,
     Year
 }
-}

Wino.Core.Domain/Enums/CalendarEventTargetType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarEventTargetType
 {
     Single, // Show details for a single event.
     Series // Show the series event. Parent of all recurring events.
 }
-}

Wino.Core.Domain/Enums/CalendarInitInitiative.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Trigger to load more data.
 /// </summary>
@@ -8,4 +8,3 @@
     User,
     App
 }
-}

Wino.Core.Domain/Enums/CalendarItemRecurrenceFrequency.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarItemRecurrenceFrequency
 {
     Daily,
@@ -7,4 +7,3 @@
     Monthly,
     Yearly
 }
-}

Wino.Core.Domain/Enums/CalendarItemReminderType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarItemReminderType
 {
     Popup,
     Email
 }
-}

Wino.Core.Domain/Enums/CalendarItemStatus.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarItemStatus
 {
     NotResponded,
@@ -7,4 +7,3 @@
     Tentative,
     Cancelled,
 }
-}

Wino.Core.Domain/Enums/CalendarItemVisibility.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarItemVisibility
 {
     Default,
@@ -7,4 +7,3 @@
     Private,
     Confidential
 }
-}

Wino.Core.Domain/Enums/CalendarLoadDirection.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Which way in time to load more data for calendar.
 /// </summary>
@@ -9,4 +9,3 @@
     Previous,
     Next
 }
-}

Wino.Core.Domain/Enums/CalendarOrientation.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarOrientation
 {
     Horizontal,
     Vertical
 }
-}

Wino.Core.Domain/Enums/CalendarSynchronizationType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CalendarSynchronizationType
 {
     ExecuteRequests, // Execute all requests in the queue.
@@ -8,4 +8,3 @@
     SingleCalendar, // Sync events for only specified calendars.
     UpdateProfile // Update profile information only.
 }
-}

Wino.Core.Domain/Enums/ChangeRequestType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum ChangeRequestType
 {
     MailMarkAs,
@@ -21,4 +21,3 @@
     SendDraft,
     FetchSingleItem
 }
-}

Wino.Core.Domain/Enums/CustomIncomingServerType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum CustomIncomingServerType
 {
     POP3,
     IMAP4
 }
-}

Wino.Core.Domain/Enums/DayHeaderDisplayType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum DayHeaderDisplayType
 {
     TwelveHour,
     TwentyFourHour,
 }
-}

Wino.Core.Domain/Enums/DraftCreationReason.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum DraftCreationReason
 {
     Empty,
@@ -7,4 +7,3 @@
     ReplyAll,
     Forward
 }
-}

Wino.Core.Domain/Enums/FilterOptionType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum FilterOptionType
 {
     All,
@@ -8,4 +8,3 @@
     Mentions,
     Files
 }
-}

Wino.Core.Domain/Enums/FolderOperation.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Defines all possible folder operations that can be done.
 /// Available values for each folder is returned by IContextMenuProvider
@@ -20,4 +20,3 @@
     CreateSubFolder,
     Seperator
 }
-}

Wino.Core.Domain/Enums/ImapAuthenticationMethod.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum ImapAuthenticationMethod
 {
     Auto,
@@ -10,4 +10,3 @@
     CramMd5,
     DigestMd5
 }
-}

Wino.Core.Domain/Enums/ImapConnectionSecurity.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum ImapConnectionSecurity
 {
     Auto,
@@ -7,4 +7,3 @@
     StartTls,
     SslTls
 }
-}

Wino.Core.Domain/Enums/InfoBarAnimationType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum InfoBarAnimationType
 {
     SlideFromRightToLeft,
     SlideFromBottomToTop
 }
-}

Wino.Core.Domain/Enums/InfoBarMessageType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum InfoBarMessageType
 {
     Information,
@@ -7,4 +7,3 @@
     Warning,
     Error
 }
-}

Wino.Core.Domain/Enums/InvalidMoveTargetReason.cs

@@ -0,0 +1,7 @@
+namespace Wino.Core.Domain.Enums;
+
+public enum InvalidMoveTargetReason
+{
+    NonMoveTarget, // This folder does not allow moving mails.
+    MultipleAccounts // Multiple mails from different accounts cannot be moved.
+}

Wino.Core.Domain/Enums/MailAttachmentType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum MailAttachmentType
 {
     None,
@@ -13,4 +13,3 @@
     Archive,
     Other
 }
-}

Wino.Core.Domain/Enums/MailImportance.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum MailImportance
 {
     Low,
     Normal,
     High
 }
-}

Wino.Core.Domain/Enums/MailListDisplayMode.cs

@@ -1,9 +1,9 @@
-namespace Wino.Core.Domain.Enums
+
-{
+namespace Wino.Core.Domain.Enums;
+
 public enum MailListDisplayMode
 {
     Spacious,
     Medium,
     Compact,
 }
-}

Wino.Core.Domain/Enums/MailMarkAsOption.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum MailMarkAsOption
 {
     WhenSelected,
     DontMark,
     AfterDelay
 }
-}

Wino.Core.Domain/Enums/MailOperation.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 // Synchronizer requests.
 public enum MailSynchronizerOperation
 {
@@ -55,4 +55,3 @@
     DiscardLocalDraft,
     Navigate // For toast activation
 }
-}

Wino.Core.Domain/Enums/MailProviderType.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum MailProviderType
 {
     Outlook,
     Gmail,
     IMAP4 = 4 // 2-3 were removed after release. Don't change for backward compatibility.
 }
-}

Wino.Core.Domain/Enums/MailSynchronizationType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum MailSynchronizationType
 {
     UpdateProfile, // Only update profile information
@@ -11,4 +11,3 @@
     Alias, // Only update alias information
     IMAPIdle // Idle client triggered synchronization.
 }
-}

Wino.Core.Domain/Enums/NavigationReferenceFrame.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum NavigationReferenceFrame
 {
     ShellFrame,
     RenderingFrame
 }
-}

Wino.Core.Domain/Enums/PickFolderReason.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Defines the potential reasons for picking folder in the folder picking dialog.
 /// </summary>
@@ -9,4 +9,3 @@
     SpecialFolder,
     Any
 }
-}

Wino.Core.Domain/Enums/PrintingResult.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum PrintingResult
 {
     Abandoned,
@@ -7,4 +7,3 @@
     Failed,
     Submitted
 }
-}

Wino.Core.Domain/Enums/SearchMode.cs

@@ -0,0 +1,6 @@
+namespace Wino.Core.Domain.Enums;
+public enum SearchMode
+{
+    Local,
+    Online
+}

Wino.Core.Domain/Enums/ServerBackgroundMode.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// What should happen to server app when the client is terminated.
 /// </summary>
@@ -9,4 +9,3 @@
     Invisible, // Still runs, tray icon is invisible.
     Terminate // Server is terminated as Wino terminates.
 }
-}

Wino.Core.Domain/Enums/SortingOptionType.cs

@@ -1,8 +1,7 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum SortingOptionType
 {
     ReceiveDate,
     Sender
 }
-}

Wino.Core.Domain/Enums/SpecialFolderType.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum SpecialFolderType
 {
     Inbox,
@@ -21,4 +21,3 @@
     Other,
     More
 }
-}

Wino.Core.Domain/Enums/SpecialImapProvider.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum SpecialImapProvider
 {
     None,
     iCloud,
     Yahoo
 }
-}

Wino.Core.Domain/Enums/StartupBehaviorResult.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum StartupBehaviorResult
 {
     Enabled,
@@ -8,4 +8,3 @@
     DisabledByPolicy,
     Fatal
 }
-}

Wino.Core.Domain/Enums/StorePurchaseResult.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 // From the SDK.
 public enum StorePurchaseResult
 {
@@ -16,4 +16,3 @@
     //     The purchase request did not succeed.
     NotPurchased,
 }
-}

Wino.Core.Domain/Enums/SynchronizationCompletedState.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum SynchronizationCompletedState
 {
     Success, // All succeeded.
     Canceled, // Canceled by user or HTTP call.
     Failed // Exception.
 }
-}

Wino.Core.Domain/Enums/SynchronizationSource.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// Enumeration for the source of synchronization.
 /// Right now it can either be from the client or the server.
@@ -9,4 +9,3 @@
     Client,
     Server
 }
-}

Wino.Core.Domain/Enums/WinoAppType.cs

@@ -1,9 +1,8 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum WinoAppType
 {
     Unknown,
     Mail,
     Calendar
 }
-}

Wino.Core.Domain/Enums/WinoCustomMessageDialogIcon.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum WinoCustomMessageDialogIcon
 {
     Information,
@@ -7,4 +7,3 @@
     Error,
     Question
 }
-}

Wino.Core.Domain/Enums/WinoPage.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 /// <summary>
 /// All registered views.
 /// </summary>
@@ -31,4 +31,3 @@
     CalendarSettingsPage,
     EventDetailsPage
 }
-}

Wino.Core.Domain/Enums/WinoServerConnectionStatus.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Enums
+namespace Wino.Core.Domain.Enums;
-{
+
 public enum WinoServerConnectionStatus
 {
     None,
@@ -8,4 +8,3 @@
     Disconnected,
     Failed
 }
-}

Wino.Core.Domain/Exceptions/AccountSetupCanceledException.cs

@@ -1,7 +1,6 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class AccountSetupCanceledException : System.Exception
 {
 
 }
-}

Wino.Core.Domain/Exceptions/AuthenticationAttentionException.cs

@@ -1,8 +1,8 @@
 using System;
 using Wino.Core.Domain.Entities.Shared;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// Thrown when IAuthenticator requires user interaction to fix authentication issues.
 /// It can be expired and can't restorable token, or some stuff that requires re-authentication.
@@ -16,4 +16,3 @@ namespace Wino.Core.Domain.Exceptions
 
     public MailAccount Account { get; }
 }
-}

Wino.Core.Domain/Exceptions/AuthenticationException.cs

@@ -1,7 +1,7 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// All exceptions related to authentication.
 /// </summary>
@@ -15,4 +15,3 @@ namespace Wino.Core.Domain.Exceptions
     {
     }
 }
-}

Wino.Core.Domain/Exceptions/BackgroundTaskRegistrationFailedException.cs

@@ -1,9 +1,8 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// An exception thrown when the background task registration is failed.
 /// </summary>
 public class BackgroundTaskRegistrationFailedException : Exception { }
-}

Wino.Core.Domain/Exceptions/ComposerMimeNotFoundException.cs

@@ -1,11 +1,10 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// Thrown when composer cant find the mime to load.
 /// </summary>
 public class ComposerMimeNotFoundException : Exception
 {
 }
-}

Wino.Core.Domain/Exceptions/CustomThemeCreationFailedException.cs

@@ -1,11 +1,10 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class CustomThemeCreationFailedException : Exception
 {
     public CustomThemeCreationFailedException(string message) : base(message)
     {
     }
 }
-}

Wino.Core.Domain/Exceptions/GmailServiceDisabledException.cs

@@ -0,0 +1,3 @@
+namespace Wino.Core.Domain.Exceptions;
+
+public class GmailServiceDisabledException : System.Exception { }

Wino.Core.Domain/Exceptions/GoogleAuthenticationException.cs

@@ -1,7 +1,6 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class GoogleAuthenticationException : System.Exception
 {
     public GoogleAuthenticationException(string message) : base(message) { }
 }
-}

Wino.Core.Domain/Exceptions/ImapClientPoolException.cs

@@ -1,14 +1,30 @@
 using System;
+using Wino.Core.Domain.Entities.Shared;
+
+namespace Wino.Core.Domain.Exceptions;
 
-namespace Wino.Core.Domain.Exceptions
-{
 public class ImapClientPoolException : Exception
 {
+    public ImapClientPoolException()
+    {
+    }
+
+    public ImapClientPoolException(string message, CustomServerInformation customServerInformation, string protocolLog) : base(message)
+    {
+        CustomServerInformation = customServerInformation;
+        ProtocolLog = protocolLog;
+    }
+
+    public ImapClientPoolException(string message, string protocolLog) : base(message)
+    {
+        ProtocolLog = protocolLog;
+    }
+
     public ImapClientPoolException(Exception innerException, string protocolLog) : base(Translator.Exception_ImapClientPoolFailed, innerException)
     {
         ProtocolLog = protocolLog;
     }
 
+    public CustomServerInformation CustomServerInformation { get; }
     public string ProtocolLog { get; }
 }
-}

Wino.Core.Domain/Exceptions/ImapConnectionFailedPackage.cs

@@ -1,7 +1,7 @@
 using Wino.Core.Domain.Models.AutoDiscovery;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class ImapConnectionFailedPackage
 {
     public ImapConnectionFailedPackage(string errorMessage, string protocolLog, AutoDiscoverySettings settings)
@@ -15,4 +15,3 @@ namespace Wino.Core.Domain.Exceptions
     public string ErrorMessage { get; set; }
     public string ProtocolLog { get; }
 }
-}

Wino.Core.Domain/Exceptions/ImapSynchronizerStrategyException.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class ImapSynchronizerStrategyException : System.Exception
 {
     public ImapSynchronizerStrategyException(string message) : base(message)
@@ -7,4 +7,3 @@
 
     }
 }
-}

Wino.Core.Domain/Exceptions/ImapTestSSLCertificateException.cs

@@ -1,5 +1,5 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class ImapTestSSLCertificateException : System.Exception
 {
     public ImapTestSSLCertificateException(string issuer, string expirationDateString, string validFromDateString)
@@ -14,4 +14,3 @@
     public string ValidFromDateString { get; set; }
 
 }
-}

Wino.Core.Domain/Exceptions/InvalidMoveTargetException.cs

@@ -1,6 +1,9 @@
 using System;
+using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
+
+public class InvalidMoveTargetException(InvalidMoveTargetReason reason) : Exception
 {
-    public class InvalidMoveTargetException : Exception { }
+    public InvalidMoveTargetReason Reason { get; } = reason;
 }

Wino.Core.Domain/Exceptions/MissingAliasException.cs

@@ -1,7 +1,6 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class MissingAliasException : System.Exception
 {
     public MissingAliasException() : base(Translator.Exception_MissingAlias) { }
 }
-}

Wino.Core.Domain/Exceptions/SynchronizerEntityNotFoundException.cs

@@ -1,11 +1,10 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class SynchronizerEntityNotFoundException : Exception
 {
     public SynchronizerEntityNotFoundException(string message) : base(message)
     {
     }
 }
-}

Wino.Core.Domain/Exceptions/SynchronizerException.cs

@@ -1,7 +1,7 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 public class SynchronizerException : Exception
 {
     public SynchronizerException(string message) : base(message)
@@ -12,4 +12,3 @@ namespace Wino.Core.Domain.Exceptions
     {
     }
 }
-}

Wino.Core.Domain/Exceptions/SystemFolderConfigurationMissingException.cs

@@ -1,7 +1,6 @@
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// When IMAP account's system folder configuration setup is not done yet.
 /// </summary>
 public class SystemFolderConfigurationMissingException : System.Exception { }
-}

Wino.Core.Domain/Exceptions/UnavailableSpecialFolderException.cs

@@ -1,8 +1,8 @@
 using System;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// Emitted when special folder is needed for an operation but it couldn't be found.
 /// </summary>
@@ -17,4 +17,3 @@ namespace Wino.Core.Domain.Exceptions
     public SpecialFolderType SpecialFolderType { get; }
     public Guid AccountId { get; set; }
 }
-}

Wino.Core.Domain/Exceptions/WinoServerException.cs

@@ -1,7 +1,7 @@
 using System;
 
-namespace Wino.Core.Domain.Exceptions
+namespace Wino.Core.Domain.Exceptions;
-{
+
 /// <summary>
 /// All server crash types. Wino Server ideally should not throw anything else than this Exception type.
 /// </summary>
@@ -9,4 +9,3 @@ namespace Wino.Core.Domain.Exceptions
 {
     public WinoServerException(string message) : base(message) { }
 }
-}

Wino.Core.Domain/Extensions/DateTimeExtensions.cs

@@ -1,8 +1,8 @@
 using System;
 using Wino.Core.Domain.Models.Calendar;
 
-namespace Wino.Core.Domain.Extensions
+namespace Wino.Core.Domain.Extensions;
-{
+
 public static class DateTimeExtensions
 {
     /// <summary>
@@ -30,4 +30,3 @@ namespace Wino.Core.Domain.Extensions
         return date.AddDays(-diff).Date;
     }
 }
-}

Wino.Core.Domain/Extensions/ExceptionExtensions.cs

@@ -1,8 +1,8 @@
 using System;
 using System.Collections.Generic;
 
-namespace Wino.Core.Domain.Extensions
+namespace Wino.Core.Domain.Extensions;
-{
+
 public static class ExceptionExtensions
 {
     public static IEnumerable<Exception> GetInnerExceptions(this Exception ex)
@@ -21,4 +21,3 @@ namespace Wino.Core.Domain.Extensions
         while (innerException != null);
     }
 }
-}

Wino.Core.Domain/Extensions/MimeExtensions.cs

@@ -1,8 +1,8 @@
 using System;
 using System.IO;
 
-namespace Wino.Core.Domain.Extensions
+namespace Wino.Core.Domain.Extensions;
-{
+
 public static class MimeExtensions
 {
     public static string GetBase64MimeMessage(this MimeKit.MimeMessage message)
@@ -17,4 +17,3 @@ namespace Wino.Core.Domain.Extensions
     public static MimeKit.MimeMessage GetMimeMessageFromBase64(this string base64)
         => MimeKit.MimeMessage.Load(new System.IO.MemoryStream(Convert.FromBase64String(base64)));
 }
-}

Wino.Core.Domain/Interfaces/IAccountCalendar.cs

@@ -1,7 +1,7 @@
 using System;
 
-namespace Wino.Core.Domain.Interfaces
+namespace Wino.Core.Domain.Interfaces;
-{
+
 public interface IAccountCalendar
 {
     string Name { get; set; }
@@ -13,4 +13,3 @@ namespace Wino.Core.Domain.Interfaces
     bool IsExtended { get; set; }
     Guid Id { get; set; }
 }
-}

Wino.Core.Domain/Interfaces/IAccountCreationDialog.cs

@@ -2,12 +2,11 @@
 using System.Threading.Tasks;
 using Wino.Core.Domain.Enums;
 
-namespace Wino.Core.Domain.Interfaces
+namespace Wino.Core.Domain.Interfaces;
-{
+
 public interface IAccountCreationDialog
 {
     Task ShowDialogAsync(CancellationTokenSource cancellationTokenSource);
     void Complete(bool cancel);
     AccountCreationDialogState State { get; set; }
 }
-}