chore: cleanup dead code + format with Pint

- Remove unused FeaturesController (empty stubs, no routes) - Remove ConvertSpatialFile CLI command (unused; service used in LayerManager) - Remove MigrateGeojsonToFeatures CLI command (one-shot migration, not referenced) - Remove .claude/worktrees/ (11 old agent worktrees from June) - Apply Laravel Pint formatting across 219 files (style only, no functional changes) Tests: 101 passing (319 assertions) API routes: unchanged (8 routes intact)
2026-08-28 13:04:28 +02:00
parent 2dccd59385
commit 90630379fb
139 changed files with 2888 additions and 2510 deletions
@@ -2,9 +2,9 @@

 namespace App\Livewire\Admin;

-use Livewire\Component;
-use Livewire\Attributes\Layout;
 use Illuminate\Support\Facades\Auth;
+use Livewire\Attributes\Layout;
+use Livewire\Component;
 use Spatie\Permission\Models\Role;
 use Spatie\Permission\PermissionRegistrar;

@@ -14,9 +14,11 @@ class RoleForm extends Component
    public ?Role $role = null;

    public string $name = '';
+
    public string $description = '';

    private const PROTECTED_ROLES = ['Admin'];
+
    private const CORE_PERMISSION = 'manage all';

    public function mount(?Role $role = null): void
@@ -24,8 +26,8 @@ class RoleForm extends Component
        abort_unless(Auth::user()?->can('manage roles'), 403);

        if ($role && $role->exists) {
-            $this->role        = $role;
-            $this->name        = $role->name;
+            $this->role = $role;
+            $this->name = $role->name;
            $this->description = $role->description ?? '';
        }
    }
@@ -33,7 +35,7 @@ class RoleForm extends Component
    public function save()
    {
        $this->validate([
-            'name'        => 'required|string|max:50|unique:roles,name' . ($this->role ? ',' . $this->role->id : ''),
+            'name' => 'required|string|max:50|unique:roles,name'.($this->role ? ','.$this->role->id : ''),
            'description' => 'nullable|string|max:255',
        ], [], ['name' => 'nombre', 'description' => 'descripción']);

@@ -46,7 +48,7 @@ class RoleForm extends Component
            $this->role->save();
        } else {
            Role::create([
-                'name'        => $this->name,
+                'name' => $this->name,
                'description' => $this->description ?: null,
            ]);
        }
@@ -2,21 +2,23 @@

 namespace App\Livewire\Admin;

-use Livewire\Component;
-use Livewire\Attributes\Layout;
 use Illuminate\Support\Facades\Auth;
-use Spatie\Permission\Models\Role;
+use Livewire\Attributes\Layout;
+use Livewire\Component;
 use Spatie\Permission\Models\Permission;
+use Spatie\Permission\Models\Role;
 use Spatie\Permission\PermissionRegistrar;

 #[Layout('layouts.app')]
 class RolePermissionManager extends Component
 {
    public string $newRole = '';
+
    public string $newPermission = '';

    /** Roles that must not be deleted or stripped of core powers. */
    private const PROTECTED_ROLES = ['Admin'];
+
    private const CORE_PERMISSION = 'manage all';

    public function mount(): void
@@ -36,7 +38,8 @@ class RolePermissionManager extends Component
        if ($role->hasPermissionTo($permissionName)) {
            // Admin must always keep the core permission
            if ($role->name === 'Admin' && $permissionName === self::CORE_PERMISSION) {
-                $this->dispatch('notify', "El rol Admin no puede perder '" . self::CORE_PERMISSION . "'.");
+                $this->dispatch('notify', "El rol Admin no puede perder '".self::CORE_PERMISSION."'.");
+
                return;
            }
            $role->revokePermissionTo($permissionName);
@@ -66,6 +69,7 @@ class RolePermissionManager extends Component

        if (in_array($role->name, self::PROTECTED_ROLES, true)) {
            $this->dispatch('notify', "El rol '{$role->name}' está protegido y no se puede borrar.");
+
            return;
        }

@@ -91,7 +95,8 @@ class RolePermissionManager extends Component
        $permission = Permission::findOrFail($permissionId);

        if ($permission->name === self::CORE_PERMISSION) {
-            $this->dispatch('notify', "El permiso '" . self::CORE_PERMISSION . "' está protegido y no se puede borrar.");
+            $this->dispatch('notify', "El permiso '".self::CORE_PERMISSION."' está protegido y no se puede borrar.");
+
            return;
        }

@@ -103,7 +108,7 @@ class RolePermissionManager extends Component
    public function render()
    {
        return view('livewire.roles.role-permission-manager', [
-            'roles'       => Role::with('permissions')->orderBy('name')->get(),
+            'roles' => Role::with('permissions')->orderBy('name')->get(),
            'permissions' => Permission::orderBy('name')->get(),
        ]);
    }
@@ -2,9 +2,9 @@

 namespace App\Livewire\Admin;

+use Illuminate\Database\Eloquent\Builder;
 use Rappasoft\LaravelLivewireTables\DataTableComponent;
 use Rappasoft\LaravelLivewireTables\Views\Column;
-use Illuminate\Database\Eloquent\Builder;
 use Spatie\Permission\Models\Role;
 use Spatie\Permission\PermissionRegistrar;

@@ -17,8 +17,8 @@ class RoleTable extends DataTableComponent
    public function configure(): void
    {
        $this->setPrimaryKey('id')
-             ->setDefaultSort('name', 'asc')
-             ->setSortingPillsEnabled(false);
+            ->setDefaultSort('name', 'asc')
+            ->setSortingPillsEnabled(false);
    }

    public function builder(): Builder
@@ -30,48 +30,48 @@ class RoleTable extends DataTableComponent
    {
        return [
            Column::make(__('Name'), 'name')
-                  ->sortable()
-                  ->searchable()
-                  ->format(fn ($value, $row) =>
-                      '<a href="'.route('admin.roles.show', $row->id).'" class="font-semibold text-primary hover:underline" wire:navigate>'.e($value).'</a>'
-                      . (in_array($row->name, self::PROTECTED_ROLES, true) ? ' <span class="badge badge-ghost badge-xs">protegido</span>' : '')
-                  )
-                  ->html(),
+                ->sortable()
+                ->searchable()
+                ->format(fn ($value, $row) => '<a href="'.route('admin.roles.show', $row->id).'" class="font-semibold text-primary hover:underline" wire:navigate>'.e($value).'</a>'
+                    .(in_array($row->name, self::PROTECTED_ROLES, true) ? ' <span class="badge badge-ghost badge-xs">protegido</span>' : '')
+                )
+                ->html(),

            Column::make(__('Description'), 'description')
-                  ->sortable()
-                  ->searchable()
-                  ->format(fn ($value) => $value
-                      ? '<span class="text-sm text-gray-500">'.e($value).'</span>'
-                      : '<span class="text-gray-300">—</span>')
-                  ->html(),
+                ->sortable()
+                ->searchable()
+                ->format(fn ($value) => $value
+                    ? '<span class="text-sm text-gray-500">'.e($value).'</span>'
+                    : '<span class="text-gray-300">—</span>')
+                ->html(),

            Column::make(__('Permissions'))
-                  ->label(fn ($row) => '<span class="badge badge-outline badge-sm">'.(int) $row->permissions_count.'</span>')
-                  ->html(),
+                ->label(fn ($row) => '<span class="badge badge-outline badge-sm">'.(int) $row->permissions_count.'</span>')
+                ->html(),

            Column::make(__('Users'))
-                  ->label(fn ($row) => '<span class="badge badge-ghost badge-sm">'.(int) $row->users_count.'</span>')
-                  ->html(),
+                ->label(fn ($row) => '<span class="badge badge-ghost badge-sm">'.(int) $row->users_count.'</span>')
+                ->html(),

            Column::make(__('Actions'))
-                  ->label(function ($row) {
-                      $show = route('admin.roles.show', $row->id);
-                      $edit = route('admin.roles.edit', $row->id);
-                      $eye   = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z"/><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M2.458 12C3.732 7.943 7.523 5 12 5c4.478 0 8.268 2.943 9.542 7-1.274 4.057-5.064 7-9.542 7-4.477 0-8.268-2.943-9.542-7z"/></svg>';
-                      $pencil = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z"/></svg>';
-                      $trash  = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M19 7l-.867 12.142A2 2 0 0116.138 21H7.862a2 2 0 01-1.995-1.858L5 7m5 4v6m4-6v6m1-10V4a1 1 0 00-1-1h-4a1 1 0 00-1 1v3M4 7h16"/></svg>';
+                ->label(function ($row) {
+                    $show = route('admin.roles.show', $row->id);
+                    $edit = route('admin.roles.edit', $row->id);
+                    $eye = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z"/><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M2.458 12C3.732 7.943 7.523 5 12 5c4.478 0 8.268 2.943 9.542 7-1.274 4.057-5.064 7-9.542 7-4.477 0-8.268-2.943-9.542-7z"/></svg>';
+                    $pencil = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M11 5H6a2 2 0 00-2 2v11a2 2 0 002 2h11a2 2 0 002-2v-5m-1.414-9.414a2 2 0 112.828 2.828L11.828 15H9v-2.828l8.586-8.586z"/></svg>';
+                    $trash = '<svg xmlns="http://www.w3.org/2000/svg" class="w-4 h-4" fill="none" viewBox="0 0 24 24" stroke="currentColor"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M19 7l-.867 12.142A2 2 0 0116.138 21H7.862a2 2 0 01-1.995-1.858L5 7m5 4v6m4-6v6m1-10V4a1 1 0 00-1-1h-4a1 1 0 00-1 1v3M4 7h16"/></svg>';

-                      $html  = '<div class="flex items-center gap-1">';
-                      $html .= '<a href="'.$show.'" class="btn btn-xs btn-ghost" title="Ver" wire:navigate>'.$eye.'</a>';
-                      $html .= '<a href="'.$edit.'" class="btn btn-xs btn-ghost text-info" title="Editar" wire:navigate>'.$pencil.'</a>';
-                      if (! in_array($row->name, self::PROTECTED_ROLES, true)) {
-                          $html .= '<button wire:click="deleteRole('.$row->id.')" wire:confirm="¿Eliminar el rol \''.e($row->name).'\'?" class="btn btn-xs btn-ghost text-error" title="Eliminar">'.$trash.'</button>';
-                      }
-                      $html .= '</div>';
-                      return $html;
-                  })
-                  ->html(),
+                    $html = '<div class="flex items-center gap-1">';
+                    $html .= '<a href="'.$show.'" class="btn btn-xs btn-ghost" title="Ver" wire:navigate>'.$eye.'</a>';
+                    $html .= '<a href="'.$edit.'" class="btn btn-xs btn-ghost text-info" title="Editar" wire:navigate>'.$pencil.'</a>';
+                    if (! in_array($row->name, self::PROTECTED_ROLES, true)) {
+                        $html .= '<button wire:click="deleteRole('.$row->id.')" wire:confirm="¿Eliminar el rol \''.e($row->name).'\'?" class="btn btn-xs btn-ghost text-error" title="Eliminar">'.$trash.'</button>';
+                    }
+                    $html .= '</div>';
+
+                    return $html;
+                })
+                ->html(),
        ];
    }

@@ -84,7 +84,9 @@ class RoleTable extends DataTableComponent
    {
        $roles = Role::whereIn('id', $this->selected)->get();
        foreach ($roles as $role) {
-            if (in_array($role->name, self::PROTECTED_ROLES, true)) continue;
+            if (in_array($role->name, self::PROTECTED_ROLES, true)) {
+                continue;
+            }
            $role->delete();
        }
        $this->clearSelected();
@@ -2,23 +2,26 @@

 namespace App\Livewire\Admin;

-use Livewire\Component;
-use Livewire\Attributes\Layout;
+use App\Models\User;
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Str;
-use App\Models\User;
-use Spatie\Permission\Models\Role;
+use Livewire\Attributes\Layout;
+use Livewire\Component;
 use Spatie\Permission\Models\Permission;
+use Spatie\Permission\Models\Role;
 use Spatie\Permission\PermissionRegistrar;

 #[Layout('layouts.app')]
 class RoleView extends Component
 {
    public Role $role;
+
    public string $tab = 'ficha';   // ficha | permisos
+
    public $newUserId = '';

    private const PROTECTED_ROLES = ['Admin'];
+
    private const CORE_PERMISSION = 'manage all';

    public function mount(Role $role): void
@@ -38,7 +41,8 @@ class RoleView extends Component
        if ($this->role->name === 'Admin'
            && $permissionName === self::CORE_PERMISSION
            && $this->role->hasPermissionTo($permissionName)) {
-            $this->dispatch('notify', "El rol Admin no puede perder '" . self::CORE_PERMISSION . "'.");
+            $this->dispatch('notify', "El rol Admin no puede perder '".self::CORE_PERMISSION."'.");
+
            return;
        }

@@ -91,6 +95,7 @@ class RoleView extends Component
    {
        if (in_array($this->role->name, self::PROTECTED_ROLES, true)) {
            $this->dispatch('notify', "El rol '{$this->role->name}' está protegido y no se puede borrar.");
+
            return;
        }
        $this->role->delete();
@@ -107,6 +112,7 @@ class RoleView extends Component
            return 'General';
        }
        $resource = Str::afterLast($name, ' ');
+
        return Str::headline($resource ?: 'General');
    }

@@ -126,6 +132,7 @@ class RoleView extends Component
            ->groupBy(fn ($perm) => $perm->group ?: $this->sectionFor($perm->name))
            ->sortBy(function ($perms, $section) use ($order) {
                $i = array_search($section, $order, true);
+
                return $i === false ? 999 : $i;
            });

@@ -133,11 +140,11 @@ class RoleView extends Component
            ->orderBy('first_name')->orderBy('name')->get();

        return view('livewire.roles.role-view', [
-            'users'          => $users,
+            'users' => $users,
            'availableUsers' => $availableUsers,
-            'grouped'        => $grouped,
-            'rolePerms'      => $this->role->permissions->pluck('name')->toArray(),
-            'isProtected'    => in_array($this->role->name, self::PROTECTED_ROLES, true),
+            'grouped' => $grouped,
+            'rolePerms' => $this->role->permissions->pluck('name')->toArray(),
+            'isProtected' => in_array($this->role->name, self::PROTECTED_ROLES, true),
        ]);
    }
 }