javier/investbrain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: uses last dividend created date as start date instead of last dividend date

Browse Source 
closes #26
This commit is contained in:
hackerESQ
2024-11-14 01:25:03 -06:00
parent 3040cbf49a
commit 1c63e2b856
2 changed files with 29 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Models/Dividend.php
+5 -5
View File
@@ -27,7 +27,7 @@ class Dividend extends Model
protected $casts = [ protected $casts = [
'date' => 'datetime', 'date' => 'datetime',
'last_date' => 'datetime', 'last_dividend_update' => 'datetime',
]; ];
public function marketData() { public function marketData() {
@@ -55,22 +55,22 @@ class Dividend extends Model
{ {
$dividends_meta = self::where(['symbol' => $symbol]) $dividends_meta = self::where(['symbol' => $symbol])
->selectRaw('COUNT(symbol) as total_dividends') ->selectRaw('COUNT(symbol) as total_dividends')
->selectRaw('MAX(date) as last_date') ->selectRaw('MAX(created_at) as last_dividend_update')
->get() ->get()
->first(); ->first();
// assume we need to populate ALL dividend data // assume we need to populate ALL dividend data
$start_date = new \DateTime('@0'); $start_date = new Carbon('@0');
$end_date = now(); $end_date = now();
// nope, refresh forward looking only // nope, refresh forward looking only
if ( $dividends_meta->total_dividends ) { if ( $dividends_meta->total_dividends ) {
$start_date = $dividends_meta->last_date->addHours(24); $start_date = $dividends_meta->last_dividend_update->addHours(24);
} }
// skip refresh if there's already recent data // skip refresh if there's already recent data
if ($start_date >= $end_date) { if ($start_date->greaterThan($end_date)) {
return; return;
} }
tests/DividendsTest.php
+22
View File
@@ -61,4 +61,26 @@ class DividendsTest extends TestCase
$this->assertCount(3, $transactions); $this->assertCount(3, $transactions);
$this->assertEqualsWithDelta(4.95, $dividendsReinvested * $market_data->market_value, 0.01); $this->assertEqualsWithDelta(4.95, $dividendsReinvested * $market_data->market_value, 0.01);
} }
/**
*/
public function test_do_not_duplicate_recent_dividends(): void
{
$this->actingAs($user = User::factory()->create());
$portfolio = Portfolio::factory()->create();
Transaction::factory()->buy()->yearsAgo()->portfolio($portfolio->id)->symbol('ACME')->create();
$holding = Holding::query()->portfolio($portfolio->id)->symbol('ACME')->first();
Dividend::create([
'symbol' => 'ACME',
'date' => now()->subDay(2),
'dividend_amount' => .01
]);
Dividend::refreshDividendData('ACME');
$this->assertCount(1, $holding->dividends);
}
} }