clean up scheduled commands

also add comments to each command
2024-09-05 21:21:18 -05:00
parent 6f63ac7067
commit 8511cc833d
12 changed files with 51 additions and 35 deletions
@@ -41,16 +41,15 @@ class RefreshMarketData extends Command
    public function handle()
    {
        // get all symbols from market data
-        $symbols = Holding::where('quantity', '>', 0)
+        $holdings = Holding::where('quantity', '>', 0)
                    ->select(['symbol'])
                    ->distinct()
-                    ->get()
-                    ->pluck('symbol');
+                    ->get();

-        foreach ($symbols as $symbol) {
-            $this->line('Refreshing ' . $symbol);
+        foreach ($holdings as $holding) {
+            $this->line('Refreshing ' . $holding->symbol);

-            MarketData::getMarketData($symbol);
+            MarketData::getMarketData($holding->symbol);
        }
    }
 }