improve naming for query scopes

2024-08-29 18:46:21 -05:00
parent 1e0a149ded
commit c522e399e8
9 changed files with 29 additions and 27 deletions
@@ -39,14 +39,16 @@ new class extends Component {

    public function holdings(): Collection
    {
-        return $this->portfolio
-                    ->holdings()
-                    ->withCount(['transactions as num_transactions' => function ($query) {
-                        $query->where('portfolio_id', $this->portfolio->id);
-                    }])
-                    ->orderBy(...array_values($this->sortBy))
-                    ->where('quantity', '>', 0)
-                    ->get();
+        $holdings = $this->portfolio
+                        ->holdings()
+                        ->withCount(['transactions as num_transactions' => function($query) {
+                            return $query->whereRaw('transactions.symbol = holdings.symbol');
+                        }])
+                        ->orderBy(...array_values($this->sortBy))
+                        ->where('holdings.quantity', '>', 0)
+                        ->get();
+
+        return $holdings;
    }

    public function goToHolding($holding)