Remove redundant logs and store tracks properly

This commit is contained in:
Lei Nelissen
2020-07-06 16:56:23 +02:00
parent 5e8fb1de9f
commit 4476ac8e54
5 changed files with 4 additions and 8 deletions

View File

@@ -45,16 +45,16 @@ const Album: React.FC = () => {
const playAlbum = usePlayAlbum(); const playAlbum = usePlayAlbum();
// Setup callbacks // Setup callbacks
const selectAlbum = useCallback(() => { playAlbum(id); }, [playAlbum]); const selectAlbum = useCallback(() => { playAlbum(id); }, [playAlbum, id]);
const selectTrack = usePlayTrack(); const selectTrack = usePlayTrack();
const refresh = useCallback(() => { dispatch(fetchTracksByAlbum(id)); }, [id]); const refresh = useCallback(() => { dispatch(fetchTracksByAlbum(id)); }, [id, dispatch]);
// Retrieve album tracks on load // Retrieve album tracks on load
useEffect(() => { useEffect(() => {
if (!album?.lastRefreshed || differenceInDays(album?.lastRefreshed, new Date()) > ALBUM_CACHE_AMOUNT_OF_DAYS) { if (!album?.lastRefreshed || differenceInDays(album?.lastRefreshed, new Date()) > ALBUM_CACHE_AMOUNT_OF_DAYS) {
refresh(); refresh();
} }
}, []); }, [album?.lastRefreshed, refresh]);
// GUARD: If there is no album, we cannot render a thing // GUARD: If there is no album, we cannot render a thing
if (!album) { if (!album) {

View File

@@ -193,7 +193,6 @@ const Albums: React.FC = () => {
getItemLayout={getItemLayout} getItemLayout={getItemLayout}
ref={listRef} ref={listRef}
keyExtractor={(item, index) => `${item}_${index}`} keyExtractor={(item, index) => `${item}_${index}`}
onScrollToIndexFailed={console.log}
renderSectionHeader={generateSection} renderSectionHeader={generateSection}
renderItem={generateItem} renderItem={generateItem}
/> />

View File

@@ -42,8 +42,6 @@ const RecentAlbums: React.FC = () => {
const retrieveData = useCallback(() => dispatch(fetchRecentAlbums()), [dispatch]); const retrieveData = useCallback(() => dispatch(fetchRecentAlbums()), [dispatch]);
const selectAlbum = useCallback((id: string) => navigation.navigate('Album', { id, album: albums[id] as Album }), [navigation, albums]); const selectAlbum = useCallback((id: string) => navigation.navigate('Album', { id, album: albums[id] as Album }), [navigation, albums]);
console.log(recentAlbums.map((d) => albums[d]?.DateCreated));
// Retrieve data on mount // Retrieve data on mount
useEffect(() => { retrieveData(); }, [retrieveData]); useEffect(() => { retrieveData(); }, [retrieveData]);

View File

@@ -30,7 +30,6 @@ class CredentialGenerator extends Component<Props> {
handleMessage = (event: WebViewMessageEvent) => { handleMessage = (event: WebViewMessageEvent) => {
// GUARD: Something must be returned for this thing to work // GUARD: Something must be returned for this thing to work
console.log(event.nativeEvent.data);
if (!event.nativeEvent.data) { if (!event.nativeEvent.data) {
return; return;
} }

View File

@@ -57,7 +57,7 @@ const music = createSlice({
* Fetch tracks by album * Fetch tracks by album
*/ */
builder.addCase(fetchTracksByAlbum.fulfilled, (state, { payload }) => { builder.addCase(fetchTracksByAlbum.fulfilled, (state, { payload }) => {
trackAdapter.setAll(state.tracks, payload); trackAdapter.upsertMany(state.tracks, payload);
// Also store all the track ids in the album // Also store all the track ids in the album
const album = state.albums.entities[payload[0].AlbumId]; const album = state.albums.entities[payload[0].AlbumId];