javier/jellyfin-audio-player
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: crash when fast-image fails to load an image

Browse Source 
There is some weird behaviour in react-native-fast-image
which causes it to crash whenever the onError or
onLoadEnd prop is set. The issue is documented in
https://github.com/DylanVann/react-native-fast-image/issues/504.
This commit is contained in:
Lei Nelissen
2023-04-12 11:31:33 +02:00
parent 5bbc3b8588
commit 67499b1103
3 changed files with 312 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
patches/react-native-fast-image+8.6.3.patch Normal file
View File

@@ -0,0 +1,22 @@
diff --git a/node_modules/react-native-fast-image/ios/FastImage/FFFastImageView.m b/node_modules/react-native-fast-image/ios/FastImage/FFFastImageView.m
index f710081..87c4532 100644
--- a/node_modules/react-native-fast-image/ios/FastImage/FFFastImageView.m
+++ b/node_modules/react-native-fast-image/ios/FastImage/FFFastImageView.m
@@ -32,7 +32,7 @@
- (void) setOnFastImageLoadEnd: (RCTDirectEventBlock)onFastImageLoadEnd {
_onFastImageLoadEnd = onFastImageLoadEnd;
- if (self.hasCompleted) {
+ if (self.hasCompleted && _onFastImageLoadEnd != NULL) {
_onFastImageLoadEnd(@{});
}
}
@@ -46,7 +46,7 @@
- (void) setOnFastImageError: (RCTDirectEventBlock)onFastImageError {
_onFastImageError = onFastImageError;
- if (self.hasErrored) {
+ if (self.hasErrored && _onFastImageError != NULL) {
_onFastImageError(@{});
}
}