Merge pull request #610 from Frooodle/fix

required false

build.gradle

@@ -8,7 +8,7 @@ plugins {
 }
 
 group = 'stirling.software'
-version = '0.18.0'
+version = '0.18.1'
 sourceCompatibility = '17'
 
 repositories {

src/main/java/stirling/software/SPDF/SPdfApplication.java

@@ -17,7 +17,7 @@ import stirling.software.SPDF.utils.GeneralUtils;
 
 @EnableScheduling
 public class SPdfApplication {
-	
+
 	@Autowired
     private Environment env;
 
@@ -29,11 +29,7 @@ public class SPdfApplication {
 
         if (browserOpen) {
             try {
-                String port = env.getProperty("local.server.port");
-                if(port == null || port.length() == 0) {
-                	port="8080";
-                }
-                String url = "http://localhost:" + port;
+                String url = "http://localhost:" + getPort();
 
                 String os = System.getProperty("os.name").toLowerCase();
                 Runtime rt = Runtime.getRuntime();
@@ -46,7 +42,7 @@ public class SPdfApplication {
             }
         }
     }
-	
+
     public static void main(String[] args) {
     	SpringApplication app = new SpringApplication(SPdfApplication.class);
     	app.addInitializers(new ConfigInitializer());
@@ -56,28 +52,28 @@ public class SPdfApplication {
             System.out.println("External configuration file 'configs/settings.yml' does not exist. Using default configuration and environment configuration instead.");
         }
         app.run(args);
-        
+
         try {
 			Thread.sleep(1000);
 		} catch (InterruptedException e) {
 			// TODO Auto-generated catch block
 			e.printStackTrace();
 		}
-        
+
         GeneralUtils.createDir("customFiles/static/");
         GeneralUtils.createDir("customFiles/templates/");
-        
-        
-        
+
         System.out.println("Stirling-PDF Started.");
-        
-        String port = System.getProperty("local.server.port");
-        if(port == null || port.length() == 0) {
-        	port="8080";
-        }
-        String url = "http://localhost:" + port;
+
+        String url = "http://localhost:" + getPort();
         System.out.println("Navigate to " + url);
     }
-    
-    
-}
+
+    public static String getPort() {
+        String port = System.getProperty("local.server.port");
+        if (port == null || port.isEmpty()) {
+            port = "8080";
+        }
+        return port;
+    }
+}

src/main/java/stirling/software/SPDF/controller/api/pipeline/ApiDocService.java

@@ -4,6 +4,7 @@ import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpHeaders;
@@ -16,23 +17,25 @@ import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 import jakarta.servlet.ServletContext;
+
+import stirling.software.SPDF.SPdfApplication;
 import stirling.software.SPDF.model.ApiEndpoint;
 import stirling.software.SPDF.model.Role;
+import org.slf4j.Logger;
 @Service
 public class ApiDocService {
 
     private final Map<String, ApiEndpoint> apiDocumentation = new HashMap<>();
 
+    private static final Logger logger = LoggerFactory.getLogger(ApiDocService.class);
+    
     @Autowired
     private ServletContext servletContext;
 
     private String getApiDocsUrl() {
         String contextPath = servletContext.getContextPath();
-        String port = System.getProperty("local.server.port");
-        if(port == null || port.length() == 0) {
-        	port="8080";
-        }
-        
+        String port = SPdfApplication.getPort();
+
         return "http://localhost:"+ port + contextPath + "/v1/api-docs";
     }
     
@@ -51,6 +54,7 @@ public class ApiDocService {
 	
 	//@EventListener(ApplicationReadyEvent.class)
 	private synchronized void loadApiDocumentation() {
+		String apiDocsJson = "";
         try {
             HttpHeaders headers = new HttpHeaders();
             String apiKey = getApiKeyForUser();
@@ -61,7 +65,7 @@ public class ApiDocService {
 
             RestTemplate restTemplate = new RestTemplate();
             ResponseEntity<String> response = restTemplate.exchange(getApiDocsUrl(), HttpMethod.GET, entity, String.class);
-            String apiDocsJson = response.getBody();
+            apiDocsJson = response.getBody();
 
             ObjectMapper mapper = new ObjectMapper();
             apiDocsJsonRootNode = mapper.readTree(apiDocsJson);
@@ -78,7 +82,7 @@ public class ApiDocService {
             });
         } catch (Exception e) {
             // Handle exceptions
-            e.printStackTrace();
+        	logger.error("Error grabbing swagger doc, body result {}", apiDocsJson);
         }
     }
 

src/main/java/stirling/software/SPDF/controller/api/pipeline/PipelineProcessor.java

@@ -34,6 +34,8 @@ import org.springframework.web.client.RestTemplate;
 import org.springframework.web.multipart.MultipartFile;
 
 import jakarta.servlet.ServletContext;
+
+import stirling.software.SPDF.SPdfApplication;
 import stirling.software.SPDF.model.PipelineConfig;
 import stirling.software.SPDF.model.PipelineOperation;
 import stirling.software.SPDF.model.Role;
@@ -47,7 +49,7 @@ public class PipelineProcessor {
 	@Autowired
 	private ApiDocService apiDocService;
     
-	@Autowired
+	@Autowired(required=false)
     private UserServiceInterface userService;
 	
 	@Autowired
@@ -65,7 +67,9 @@ public class PipelineProcessor {
 
 	private String getBaseUrl() {
 		String contextPath = servletContext.getContextPath();
-		return "http://localhost:8080" + contextPath + "/";
+		String port = SPdfApplication.getPort();
+
+		return "http://localhost:" + port + contextPath + "/";
 	}